-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check: fee distribution on failed tx #149
base: main
Are you sure you want to change the base?
Conversation
x/feemarket/ante/suite/suite.go
Outdated
if tc.RunPost && anteErr == nil { | ||
newCtx, postErr = s.PostHandler(s.Ctx, tx, tc.Simulate, true) | ||
if tc.RunPost { | ||
newCtx, postErr = s.PostHandler(s.Ctx, tx, tc.Simulate, anteErr == nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should always run the post handler in these tests even if there is an ante handler error. https://docs.cosmos.network/v0.50/learn/advanced/baseapp#runmsgs
@@ -169,7 +169,7 @@ func TestAnteHandleMock(t *testing.T) { | |||
} | |||
}, | |||
RunAnte: true, | |||
RunPost: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these were ante handler tests that should not be running a post handler
Attempt to check if failed tx's result in stuck escrow when
DistributeFees
is true