Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check: fee distribution on failed tx #149

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

aljo242
Copy link
Collaborator

@aljo242 aljo242 commented Oct 19, 2024

Attempt to check if failed tx's result in stuck escrow when DistributeFees is true

if tc.RunPost && anteErr == nil {
newCtx, postErr = s.PostHandler(s.Ctx, tx, tc.Simulate, true)
if tc.RunPost {
newCtx, postErr = s.PostHandler(s.Ctx, tx, tc.Simulate, anteErr == nil)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should always run the post handler in these tests even if there is an ante handler error. https://docs.cosmos.network/v0.50/learn/advanced/baseapp#runmsgs

@@ -169,7 +169,7 @@ func TestAnteHandleMock(t *testing.T) {
}
},
RunAnte: true,
RunPost: true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were ante handler tests that should not be running a post handler

@aljo242 aljo242 marked this pull request as draft October 19, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants